-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query log's «Client» field doesn't support searching by client nicknames #1273
Comments
@szolin no prob |
One potential makeshift alternative that I only came up with just now, would've been to allow something like '123.45.67.89 + 87.65.43.21' or '123.45.67.89 OR 87.65.43.21', like what can be done in certain search engines to include search results for multiple terms at once. |
ghost
mentioned this issue
Feb 12, 2020
ghost
mentioned this issue
Apr 1, 2020
adguard
pushed a commit
that referenced
this issue
Apr 2, 2021
Updates #1273. Squashed commit of the following: commit 55b7815 Author: Artem Baskal <a.baskal@adguard.com> Date: Fri Apr 2 16:55:39 2021 +0300 Update client_info in case of null commit 5c80c14 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Apr 2 16:24:14 2021 +0300 querylog: always set client_info commit b48efd6 Merge: 4ed7eab 23c9f52 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Apr 2 16:22:08 2021 +0300 Merge branch 'master' into 1273-querylog-client-name commit 4ed7eab Merge: dbf990e 70d4c70 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Apr 2 12:57:17 2021 +0300 Merge branch 'master' into 1273-querylog-client-name commit dbf990e Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Apr 2 12:56:13 2021 +0300 home: imp names commit c2cfdef Author: Artem Baskal <a.baskal@adguard.com> Date: Thu Apr 1 19:26:04 2021 +0300 Rename to whois commit e3cc4a6 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Thu Apr 1 19:03:42 2021 +0300 home: imp whois more commit 3b8ef86 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Thu Apr 1 18:51:14 2021 +0300 home: imp whois resp commit fb97e0d Author: Artem Baskal <a.baskal@adguard.com> Date: Thu Apr 1 18:00:03 2021 +0300 Fix client_info ids prop types commit 2980051 Author: Artem Baskal <a.baskal@adguard.com> Date: Thu Apr 1 17:58:14 2021 +0300 Adapt changes on client commit aa1769f Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Thu Apr 1 17:18:36 2021 +0300 all: add more fields to querylog client commit 4b2a2db Merge: cda92c3 2e4e2f6 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Thu Apr 1 16:57:26 2021 +0300 Merge branch 'master' into 1273-querylog-client-name commit cda92c3 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Mar 29 18:03:51 2021 +0300 querylog: fix windows tests commit 5a56f0a Merge: 627e495 e710ce1 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Mar 29 17:45:53 2021 +0300 Merge branch 'master' into 1273-querylog-client-name commit 627e495 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Mar 29 17:44:49 2021 +0300 querylog: add tests, imp code, docs commit 6dec468 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Mar 26 16:10:47 2021 +0300 querylog: search clients by name, enrich http resp
The name search is implemented as of snapshot 7c35d20. Is there anything else to be done here? |
Looks good to me |
adguard
pushed a commit
that referenced
this issue
Apr 12, 2021
Updates #1273. Squashed commit of the following: commit 6c2cc73 Merge: effe223 fb72d54 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Apr 12 14:05:04 2021 +0300 Merge branch 'master' into 1273-querylog-opt commit effe223 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Apr 12 13:21:06 2021 +0300 querylog: opt client search
adguard
pushed a commit
that referenced
this issue
Aug 16, 2021
Merge in DNS/adguard-home from 3438-inputs-height to master Squashed commit of the following: commit a049feb Merge: 7035339 42b2c3a Author: Ildar Kamalov <ik@adguard.com> Date: Mon Aug 16 17:36:58 2021 +0300 Merge branch 'master' into 3438-inputs-height commit 7035339 Merge: 20ef34c 784bc31 Author: Ildar Kamalov <ik@adguard.com> Date: Mon Aug 16 17:28:06 2021 +0300 Merge branch 'master' into 3438-inputs-height commit 20ef34c Author: Ildar Kamalov <ik@adguard.com> Date: Mon Aug 16 13:41:46 2021 +0300 client: remove unused commit f2ace4e Author: Ildar Kamalov <ik@adguard.com> Date: Mon Aug 16 13:30:58 2021 +0300 client: make highlighted inputs resizable
heyxkhoa
pushed a commit
to heyxkhoa/AdGuardHome
that referenced
this issue
Mar 20, 2023
Updates AdguardTeam#1273. Squashed commit of the following: commit 55b7815 Author: Artem Baskal <a.baskal@adguard.com> Date: Fri Apr 2 16:55:39 2021 +0300 Update client_info in case of null commit 5c80c14 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Apr 2 16:24:14 2021 +0300 querylog: always set client_info commit b48efd6 Merge: 4ed7eab 23c9f52 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Apr 2 16:22:08 2021 +0300 Merge branch 'master' into 1273-querylog-client-name commit 4ed7eab Merge: dbf990e 70d4c70 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Apr 2 12:57:17 2021 +0300 Merge branch 'master' into 1273-querylog-client-name commit dbf990e Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Apr 2 12:56:13 2021 +0300 home: imp names commit c2cfdef Author: Artem Baskal <a.baskal@adguard.com> Date: Thu Apr 1 19:26:04 2021 +0300 Rename to whois commit e3cc4a6 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Thu Apr 1 19:03:42 2021 +0300 home: imp whois more commit 3b8ef86 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Thu Apr 1 18:51:14 2021 +0300 home: imp whois resp commit fb97e0d Author: Artem Baskal <a.baskal@adguard.com> Date: Thu Apr 1 18:00:03 2021 +0300 Fix client_info ids prop types commit 2980051 Author: Artem Baskal <a.baskal@adguard.com> Date: Thu Apr 1 17:58:14 2021 +0300 Adapt changes on client commit aa1769f Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Thu Apr 1 17:18:36 2021 +0300 all: add more fields to querylog client commit 4b2a2db Merge: cda92c3 2e4e2f6 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Thu Apr 1 16:57:26 2021 +0300 Merge branch 'master' into 1273-querylog-client-name commit cda92c3 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Mar 29 18:03:51 2021 +0300 querylog: fix windows tests commit 5a56f0a Merge: 627e495 e710ce1 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Mar 29 17:45:53 2021 +0300 Merge branch 'master' into 1273-querylog-client-name commit 627e495 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Mar 29 17:44:49 2021 +0300 querylog: add tests, imp code, docs commit 6dec468 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Fri Mar 26 16:10:47 2021 +0300 querylog: search clients by name, enrich http resp
heyxkhoa
pushed a commit
to heyxkhoa/AdGuardHome
that referenced
this issue
Mar 20, 2023
Updates AdguardTeam#1273. Squashed commit of the following: commit 6c2cc73 Merge: effe223 fb72d54 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Apr 12 14:05:04 2021 +0300 Merge branch 'master' into 1273-querylog-opt commit effe223 Author: Ainar Garipov <A.Garipov@AdGuard.COM> Date: Mon Apr 12 13:21:06 2021 +0300 querylog: opt client search
heyxkhoa
pushed a commit
to heyxkhoa/AdGuardHome
that referenced
this issue
Mar 20, 2023
Merge in DNS/adguard-home from 3438-inputs-height to master Squashed commit of the following: commit a049feb Merge: 7035339 42b2c3a Author: Ildar Kamalov <ik@adguard.com> Date: Mon Aug 16 17:36:58 2021 +0300 Merge branch 'master' into 3438-inputs-height commit 7035339 Merge: 20ef34c 784bc31 Author: Ildar Kamalov <ik@adguard.com> Date: Mon Aug 16 17:28:06 2021 +0300 Merge branch 'master' into 3438-inputs-height commit 20ef34c Author: Ildar Kamalov <ik@adguard.com> Date: Mon Aug 16 13:41:46 2021 +0300 client: remove unused commit f2ace4e Author: Ildar Kamalov <ik@adguard.com> Date: Mon Aug 16 13:30:58 2021 +0300 client: make highlighted inputs resizable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prerequisites
Issue Details
In the Query Log list, the Clients textfield does not support any sort of searching by client nicknames whatsoever, regardless of if the nicknames were given through AGH's Client settings menu, the RaspPi's /etc/hosts file, or the client units' own callcode names (e.g.
PC-GHWJCIOR
).Supporting searches by client nicknames would've been hugely advantageous if one wants to look up the query logs of multiple but similar things at the same time, be they similar in model, brand, or owner. Currently the only way to do that is with very careful assignment of static IPs to make them have IP addresses next to each other (e.g.
192.168.1.90
and192.168.1.91
, while assigning no other192.168.1.9x
IPs to anything), which is impractical for many people.Since I've already named my static-IP clients by product model and in most cases also owner names, it'd have been amazing to be able to e.g. search with Yamaha if one owns multiple surround receivers, T-We if one owns multiple models of that Scandinavian cable TV set-top box brand, [My mom's name] to look through all the units someone is owning, or telenor to look through connections from a specific 4G provider.
Expected Behavior
That text input in the Clients textbox, leads to the query list filtering down to clients whose nicknames contain such text.
Actual Behavior
No entries show up with any letter-containing search of any kind (See screenshot below).
Screenshots
Screenshot:
Additional Information
None in particular.
The text was updated successfully, but these errors were encountered: