Update README explaining that the layout needs a gyroscope #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sloy
requested changes
Nov 2, 2016
| @@ -155,6 +155,9 @@ For bugs, requests, questions and discussions please use [Github Issues](https:/ | |||
| # Attributions | |||
| This library was developed by [Rafa Vázquez](https://github.com/Sloy/) with the idea of moving images from [Alex Bailón](https://github.com/abailon) for the [Infojobs' Android application](https://play.google.com/store/apps/details?id=net.infojobs.mobile.android). | |||
|
|
|||
| # Device requirements | |||
| This layout needs a gyroscope powered device. Sadly, there are some low-end phones that doesn't have it. In that case, the layed image won't move, but it will appear great. | |||
There was a problem hiding this comment.
About "it will appear great": we understand each other, but it might be a bit too happy for a public lib :p
Maybe better specify that it will look as a normal still image?
Closed
Sloy
approved these changes
Nov 2, 2016
|
And that's my proposal! :·) |
|
Your proposal looks good to me 👍 |
|
Great! Feel free to merge it, @Sloy :·) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with #8, we tried to develop a version that simply uses the accelerometer and the compass... but we failed using phones that don't have some of that sensors. Incredible.
As the complexity of the library grows exponentially, we will simply talk about using a phone with a gyroscope in the readme. The layout shows the image also with low-end phones that don't have those sensors, so it's not a big deal.