Avoid registering the sensor if it's null #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be related to #8, but crashing because of a non-safe implementation on Android 4. Just a hypothesis 🤔 Thanks for the fix!! |
|
BTW nice branch name 😆 |
|
Whoop, just did a nextnextnext in the GitHub editor :·) |
|
@rocboronat fix now published on v1.1.1. God save CI! |
|
Thanks, @Sloy ! Just updating our version and launching it to Google Play! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, some phones return a null sensor when getting the default one. So, we will check for it before registering the sensort to avoid crashes like http://crashes.to/s/2fd03a11431
BTW, sorry for the last line. I edited the file using the website so I don't have any idea about why it has changed :·/