Add a method to click a radio button by position #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocboronat
changed the title
Sloy
reviewed
Mar 30, 2017
| @Test | ||
| public void checkRadioButtonsByPosition_firstItem() { | ||
| clickRadioButtonPosition(R.id.radiogroup, 0); | ||
| assertDisplayed("" + R.id.first_item); |
There was a problem hiding this comment.
Why this assertDisplayed and this concatenation?
There was a problem hiding this comment.
It's the same way we're checking that the ID of that item has been clicked. If you have a better idea... we could implement it in another PR, and change other methods as well :·D
SmasSive
approved these changes
Mar 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here it comes! @Sloy as I needed a place to add Matchers, I used your class
HelperMatchersat #38 . So, you will just add a method to that class if this PR is merged faster than yours :·)By the way, the matcher this PR adds could be very useful for other tasks at Barista.