Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop adde-lint, use sass-lint + prettier for "lint:sass" run script #1164

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

bantic
Copy link
Contributor

@bantic bantic commented Feb 6, 2025

Related to #1163.

This drops the adde-lint --sass in favor of using the underlying commands directly.

The adde-lint subcommand (defined here) runs both sass-lint and prettier:

https://github.com/Addepar/addepar-ember-toolbox/blob/897b838c696c422bdf70c81983e6ecc29db2e34b/lib/lint.js#L163-L166

which in turn are defined at:

https://github.com/Addepar/addepar-ember-toolbox/blob/897b838c696c422bdf70c81983e6ecc29db2e34b/lib/lint.js#L115-L140

I added a log line at https://github.com/Addepar/addepar-ember-toolbox/blob/897b838c696c422bdf70c81983e6ecc29db2e34b/lib/lint.js#L22 to double-check the exact commands that are run.

A few minor changes:

  • expand the CLI flags to long form (--verbose --no-exit instead of -vq for sass-lint, --list-files for prettier)
  • explicitly pass the config to sass-lint via --config flag

The glob paths passed to prettier are the same ones that adde-lint would -- it checks for presence of certain paths on disk and concats all the dirs it finds. I've left it the same for future-proofing, although there are no scss files in addon/.

Notes:

  • The way this is setup (before and after this PR), there is no sass-lint-ing of the scss files for the tests dummy app. I did not enable that for this PR because it results in a handful of failures
  • There are some .css files in this repo; they are not linted (via sass-lint or prettier). This PR doesn't change that

@mixonic mixonic merged commit bb14544 into master Feb 6, 2025
9 checks passed
@mixonic mixonic deleted the bantic/webcore-3168-sass branch February 6, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants