Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Description has http://go.addtocalendar.com in it #17

Closed
elie222 opened this issue Sep 19, 2016 · 29 comments
Closed

Description has http://go.addtocalendar.com in it #17

elie222 opened this issue Sep 19, 2016 · 29 comments
Labels
wontfix

Comments

@elie222
Copy link

elie222 commented Sep 19, 2016 •
edited by atc-master
Loading

Note! Ask support@addtocalendar.com for tag line changes!

Why does the description automatically add:

http://go.addtocalendar.com

to the end of it?
@thoughtpalette
Copy link

^ That's pretty damn sneaky.

@thoughtpalette
Copy link

I've sent them an email regarding this issue.

@measureddesigns
Copy link

+1

3 similar comments
@RyanMadsen
Copy link

+1

@akhildave
Copy link

+1

@jamesonnuss
Copy link

+1

@birdspider
Copy link

birdspider commented Nov 30, 2016 •
edited
Loading

I too just stumbled upon this and it worries me, I seems that the links it produces i.e.

http://addtocalendar.com/atc/google?utz=60&uln=en&vjs=1.5&e[0][date_start]=2016-11-30%2000%3A00%3A00&e[0][date_end]=2016-12-03%2011%3A00%3A00&e[0][timezone]=Europe%2FBerlin&e[0][title]=some%20title&e[0]
[description]=some%20descr&e[0][location]=somewhere

get ping-ponged to http://addtocalendar.com/atc/google - which I presume prepares a special calendar-target specific redirect

like so:

(check out the Location Header - there is the --%0Ahttp%3A%2F%2Fgo.addtocalendar.com text)

curl -v --globoff "http://addtocalendar.com/atc/google?utz=60&uln=en&vjs=1.5&e[0][date_start]=2016-11-30%2000%3A00%3A00&e[0][date_end]=2016-12-03%2011%3A00%3A00&e[0][timezone]=Europe%2FBerlin&e[0][title]=some%20title&e[0][description]=some%20descr&e[0][location]=somewhere"
*   Trying 35.162.86.54...
* TCP_NODELAY set
* Connected to addtocalendar.com (35.162.86.54) port 80 (#0)
> GET /atc/google?utz=60&uln=en&vjs=1.5&e[0][date_start]=2016-11-30%2000%3A00%3A00&e[0][date_end]=2016-12-03%2011%3A00%3A00&e[0][timezone]=Europe%2FBerlin&e[0][title]=some%20title&e[0][description]=some%20descr&e[0][location]=somewhere HTTP/1.1
> Host: addtocalendar.com
> User-Agent: curl/7.51.0
> Accept: */*
> 
< HTTP/1.1 302 Found
< Server: nginx
< Content-Type: text/html; charset=UTF-8
< Transfer-Encoding: chunked
< Connection: keep-alive
< Cache-Control: no-cache
< Date: Wed, 30 Nov 2016 19:04:04 GMT
< Location: https://www.google.com/calendar/render?action=TEMPLATE&dates=20161129T230000Z/20161203T100000Z&location=somewhere&text=some+title&details=some+descr%0A%0A--%0Ahttp%3A%2F%2Fgo.addtocalendar.com
< Set-Cookie: m=rB8YsVg/IqSufkiLTHuNAg==; expires=Thu, 30-Nov-17 19:04:04 GMT; path=/
< 
<!DOCTYPE html>
<html>
    <head>
        <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
        <meta http-equiv="refresh" content="1;url=https://www.google.com/calendar/render?action=TEMPLATE&amp;dates=20161129T230000Z/20161203T100000Z&amp;location=somewhere&amp;text=some+title&amp;details=some+descr%0A%0A--%0Ahttp%3A%2F%2Fgo.addtocalendar.com" />

        <title>Redirecting to https://www.google.com/calendar/render?action=TEMPLATE&amp;dates=20161129T230000Z/20161203T100000Z&amp;location=somewhere&amp;text=some+title&amp;details=some+descr%0A%0A--%0Ahttp%3A%2F%2Fgo.addtocalendar.com</title>
    </head>
    <body>
        Redirecting to <a href="https://www.google.com/calendar/render?action=TEMPLATE&amp;dates=20161129T230000Z/20161203T100000Z&amp;location=somewhere&amp;text=some+title&amp;details=some+descr%0A%0A--%0Ahttp%3A%2F%2Fgo.addtocalendar.com">https://www.google.com/calendar/render?action=TEMPLATE&amp;dates=20161129T230000Z/20161203T100000Z&amp;location=somewhere&amp;text=some+title&amp;details=some+descr%0A%0A--%0Ahttp%3A%2F%2Fgo.addtocalendar.com</a>.
    </body>
* Curl_http_done: called premature == 0
* Connection #0 to host addtocalendar.com left intact

I don't see any reason for this in at least in the gmail calendar variant - other then sitting in MITM position.

Even more worring is the lack of information on the product page: http://addtocalendar.com/ no actual contact information on page nor on npmjs.com. For all intents and purposes I see this a nice datamining app.

I might be horribly wrong - anyone care to comment?

@elie222
Copy link
Author

elie222 commented Nov 30, 2016 via email

@birdspider
Copy link

@elie222 : I'm pretty much done (features that I need), I'll post here when I have something to show/tested/uploaded.

@jamesonnuss
Copy link

@elie222 @birdspider Thank you. I am still trying to find an alternative. Looking forward to your post.

@blcarson
Copy link

blcarson commented Dec 1, 2016

+1 for this. Also need to add an all-day option so clients dont see crap like this:

screenshot 1

@birdspider
Copy link

@elie222 there you go https://github.com/birdspider/calendarium
@blcarson done for google and ics

beware - for ics (Outlook, Thunderbird) you'll need to implement your own backend

@blcarson
Copy link

blcarson commented Dec 2, 2016

@birdspider Awesome! Will look into this more over the weekend. If you need any help with styling and whatnot let me know - would be happy to help.

@birdspider
Copy link

@blcarson I has basicly no styles yet, just a minimal set and a "plain" mode to make I a bit nicer, I do not plan to provide extensive extra styling but contributions are welcome.

@atc-master
Copy link
Contributor

The "http://go.addtocalendar.com" link just tells users about the widget. Nothing special.

@elie222
Copy link
Author

elie222 commented Jan 25, 2017 via email

@atc-master
Copy link
Contributor

atc-master commented Jan 25, 2017 •
edited
Loading

@elie222 this is like a logo. You use Github and you see Octocat everywhere. You buy coffee in Starbucks and you see Starbucks logo everywhere. Look at your phone. What you see? Logo.

But why you so fear the widget website "logo" in the event description?

@elie222
Copy link
Author

elie222 commented Jan 25, 2017 via email

@sigma-technology
Copy link

I understand that you don't want it elie, and neither do I, but I also think it's unfair to expect the creators of this not to receive some credit for their work. The widget is using code on their server to generate the ICS files, so you are using THEIR resources for free, and you're still complaining about a bit of branding? Either build your own widget, or re-assess your sense of entitlement.

@elie222
Copy link
Author

elie222 commented Jan 25, 2017 via email

@atc-master
Copy link
Contributor

@elie222 how much money you suggest/could pay for remove the tagline?

@SigmaTec is right. AddToCalendar is a very simple to use solution for end user. The generation process is encapsulated in backend and we support it. The idea of tag line is just tell users about us.

But I understand @elie222. When you get the package from github you should know about this behavior. We have task for review and actualization our github repository after long time of freeze.

@elie222
Copy link
Author

elie222 commented Jan 25, 2017 via email

@Renrhaf
Copy link

Renrhaf commented Apr 11, 2017

Agreed with @elie222 that it should be written somewhere because my team and I, are using it on a new website and now the client complains about this "ad". So I need to switch to an other solution, unfortunately...

@zaisahil
Copy link

Is there any other solution ? Or a way to remove this? Please help! I am stuck very badly and can't find some other free version with such facilities.

@atc-master
Copy link
Contributor

atc-master commented Jul 10, 2017 •
edited
Loading

Please write to support@addtocalendar.com

@zaisahil

@elie222
Copy link
Author

elie222 commented Jul 10, 2017 •
edited
Loading

@zaisahil yes this a solution without silly branding. This was posted above:
https://github.com/birdspider/calendarium

@elie222
Copy link
Author

elie222 commented Jul 10, 2017

I made an update to the README so that others don't waste their time if they don't want addtocalendar.com in their events:
https://github.com/AddToCalendar/addtocalendar/pull/38/files

@atc-master
Copy link
Contributor

@elie222 I've changed the README according your comments. Please take a look.

@rruprai
Copy link

rruprai commented Aug 23, 2018 •
edited
Loading

Looks like addtocalendar has merged with AddEvents. I have found that if you do a custom solution, the link will not be in the .ics file.

Here is an example (link)

<!-- AddEvent script -->
<script type="text/javascript" src="https://addevent.com/libs/atc/1.6.1/atc.min.js" async defer></script>

<!-- Button code -->
<div title="Add to Calendar" class="addeventatc">
    Add to Calendar
    <span class="start">09/06/2018 08:00 AM</span>
    <span class="end">09/06/2018 10:00 AM</span>
    <span class="timezone">America/Los_Angeles</span>
    <span class="title">Summary of the event</span>
    <span class="description">Description of the event</span>
    <span class="location">Location of the event</span>
</div>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests