Add a shared libraries closure check to anod spec #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grouigrokon
commented
Jul 1, 2024
grouigrokon
force-pushed
the
add-anod-check-dll-closure
branch
from
1b97a38
to
0189a87
Compare
enzbang
reviewed
Jul 1, 2024
grouigrokon
force-pushed
the
add-anod-check-dll-closure
branch
from
0189a87
to
7fbdcaf
Compare
enzbang
reviewed
Jul 1, 2024
grouigrokon
force-pushed
the
add-anod-check-dll-closure
branch
2 times, most recently
from
576d76d
to
0e51713
Compare
grouigrokon
changed the title
enzbang
reviewed
Jul 2, 2024
The `check_shared_libraries_closure()` methods allows to make sure the shared library of a spec only link with valid shared libraries. For instance, when linking with our own version of `zlib`, we want to make sure that the built shared libraries do not link with `/usr/lib/libz.so`, but with our `zlib`.
grouigrokon
force-pushed
the
add-anod-check-dll-closure
branch
from
0e51713
to
7997124
Compare
enzbang
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
check_shared_libraries_closure()methods allows to make sure theshared library of a spec only link with valid shared libraries.
For instance, when linking with our own version of
zlib, we wantto make sure that the built shared libraries do not link with
/usr/lib/libz.so, but with ourzlib.