Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e3.anod.spec.Anod.deps_source_list #606

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add e3.anod.spec.Anod.deps_source_list #606

wants to merge 1 commit into from

Conversation

leocardao
Copy link
Contributor

@leocardao leocardao commented Jul 21, 2023 •
edited
Loading

e3.anod.spec.Anod.deps_source_list contain the dependencies source list (any e3.anod.deps.Dependency that require 'source_pkg')

e3.anod.spec.Anod.deps will not reference anymore the source_pkg dependencies.

@leocardao leocardao requested a review from Nikokrock July 21, 2023 12:19
grouigrokon
grouigrokon reviewed Jul 21, 2023
View reviewed changes
src/e3/anod/context.py Outdated Show resolved Hide resolved
@leocardao leocardao self-assigned this Jul 24, 2023
@leocardao leocardao force-pushed the mr/cardao/split-deps-and-sources branch from 18f516b to 4084a6b Compare July 26, 2023 13:10
grouigrokon
grouigrokon reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@grouigrokon grouigrokon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel like you want with the two typoes. If you want to let them be, it is not an enormous matter :)

src/e3/anod/context.py Outdated Show resolved Hide resolved
src/e3/anod/driver.py Outdated Show resolved Hide resolved
@leocardao leocardao force-pushed the mr/cardao/split-deps-and-sources branch from 4084a6b to 8ac8fd5 Compare August 3, 2023 14:33
@leocardao
Add e3.anod.spec.Anod.source_list
c0eba37 
e3.anod.spec.Anod.source_list contain the dependencies source list
(any e3.anod.deps.Dependency that require 'source_pkg')

e3.anod.spec.Anod.deps will not reference anymore the source_pkg
dependencies.
@leocardao leocardao force-pushed the mr/cardao/split-deps-and-sources branch from 8ac8fd5 to c0eba37 Compare August 3, 2023 14:36
Nikokrock
Nikokrock reviewed Aug 4, 2023
View reviewed changes
Copy link
Contributor

@Nikokrock Nikokrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a cannot approve as some specs use Source dep to access spec functions. I saw them while rewriting some .anod. We need to change those specs first

@leocardao leocardao changed the title Add e3.anod.spec.Anod.source_list Add e3.anod.spec.Anod.deps_source_list Sep 7, 2023
@leocardao leocardao marked this pull request as draft November 15, 2023 10:44
@leocardao leocardao closed this Jan 17, 2024
@leocardao leocardao reopened this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nikokrock Nikokrock Nikokrock left review comments

@grouigrokon grouigrokon grouigrokon approved these changes

@liaiss liaiss Awaiting requested review from liaiss

Assignees

@leocardao leocardao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leocardao @Nikokrock @grouigrokon