Water - Christabel #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc364ed.
…k helper to peek at last added value
CheezItMan
reviewed
Apr 15, 2021
Comment on lines
+5
to
8
| Time Complexity: O(n) | ||
| Space Complexity: O(n) | ||
| */ | ||
| const balanced = (str) => { |
Comment on lines
+48
to
51
| Time Complexity: O(n) | ||
| Space Complexity: O(n) | ||
| */ | ||
| const evaluatePostfix = (expr) => { |
| } | ||
|
|
||
| enqueue(element) { | ||
| throw new Error("This method has not been implemented!"); | ||
| enqueue(value) { |
| } else { | ||
| this.rear++; | ||
| } | ||
| this.store[this.rear] = value; | ||
| } | ||
|
|
||
| dequeue() { |
| const dequeued = this.store[this.front]; | ||
| this.store[this.front] = null; | ||
|
|
||
| return dequeued; | ||
| } | ||
|
|
||
| front() { |
| } | ||
|
|
||
| front() { | ||
| throw new Error("This method has not been implemented!"); | ||
| return this.store[front]; | ||
| } | ||
|
|
||
| size() { |
There was a problem hiding this comment.
🤔 I'm not sure this this will work in all cases.
Comment on lines
+49
to
+53
| if (this.front == this.rear) { | ||
| return true; | ||
| } else { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Maybe just do this
Suggested change
| if (this.front == this.rear) { | |
| return true; | |
| } else { | |
| return false; | |
| } | |
| return this.front == this.rear; |
| @@ -1,19 +1,31 @@ | |||
| const LinkedList = require("./linked-list"); | |||
|
|
|||
| class Stack { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.