-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earth/Taylor/Lina #4
base: master
Are you sure you want to change the base?
Conversation
Slack CLIMajor Learning Goals/Code Review
Functional Requirements
Overall FeedbackGreat work!! Y'all made a whole program that interacts with Slack in real time from the command terminal!! See my inline comments as well for more detailed feedback
Code Style Bonus AwardsWas the code particularly impressive in code style for any of these reasons (or more...?)
|
|
||
private | ||
|
||
def self.from_api(recipient) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clever and clean that this is a separate method and you made it private!
when "select user" | ||
puts "User name or ID?" | ||
user = gets.chomp | ||
selected_item = workspace.select_user(user) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because slack.rb is already doing a lot, it would make the program easier for people to read and understand if the Workspace class had an instance variable had an instance variable to track which Recipient is currently selected instead of tracking it here.
return selected | ||
end | ||
|
||
def send_message(selected_item, text) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only seems to work for sending messages to channels but not users. Did y'all realize that as you were building it and testing it out?
Assignment Submission: Slack CLI
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection