Fire - Jing & Stacy #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 23, 2020
Comment on lines
+3
to
+4
| ##################### wave 1 | ||
| def draw_letters |
| def uses_available_letters?(input, letters_in_hand) | ||
| input_letters = input.split("") | ||
| if input_letters.length > 10 | ||
| puts "Oops, too many letters! You only have 10 :)" |
There was a problem hiding this comment.
You don't need to do puts here. Just return false or raise an error. Probably raising an error makes sense here.
Suggested change
| puts "Oops, too many letters! You only have 10 :)" |
|
|
||
| counts_input.each_pair do |letter, count| | ||
| if counts_input[letter].length > counts_letterinhand[letter].length | ||
| puts "Looks like you use #{letter} too many times." |
There was a problem hiding this comment.
Suggested change
| puts "Looks like you use #{letter} too many times." |
Comment on lines
+38
to
+39
| counts_input = input_letters.group_by {|letter| letter} | ||
| counts_letterinhand = letters_in_hand.group_by {|letter| letter} |
There was a problem hiding this comment.
Clever use of group_by
| end | ||
|
|
||
| ############################# wave 3 | ||
| def score_word(word) |
Comment on lines
+87
to
+88
| ######################### wave 4 | ||
| def highest_score_from(words) |
There was a problem hiding this comment.
Nice uses of select and max_by.
Comment on lines
+117
to
+118
| ######################### wave 5 | ||
| def is_in_english_dict?(input) |
There was a problem hiding this comment.
Well done, you got the optional dictionary!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Adagrams
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
Enumerablemixin? If so, where and why was it helpful?