Raisah #24
Open
Raisah #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 18, 2020
Comment on lines
+4
to
+6
| # Time Complexity: O(nlogn + nlogn) The heapsort will iterate n times through the list to add elements to the heap, taking logn times at worst each time and then the heapsort will iterate n times through the heap to remove elements, taking logn times at worst to remove elements. This reduces to O(nlogn) | ||
| # Space Complexity: O(n) the heapsort function creates a heap of n size when sorting. | ||
| def heapsort(list) |
There was a problem hiding this comment.
You can reduce the time complexity to O(n log n). Otherwise this works well.
Comment on lines
+17
to
19
| # Time Complexity: O(logn) At worse, the heap_up function will have to iterate logn times to add a heapnode from the leaf to the root of the heap | ||
| # Space Complexity: O(logn) the heap_up function doesn't store additional variables, but does make logn recursive calls to the memory stack in worst case | ||
| def add(key, value = key) |
Comment on lines
+27
to
29
| # Time Complexity: O(logn) At worse, the heap_down function will have to iterate logn times to remove a heapnode | ||
| # Space Complexity: O(logn) the remove function doesn't store additional variables, but does make logn recursive calls to the memory stack in worst case | ||
| def remove() |
Comment on lines
+56
to
58
| # Time complexity: O(n) checks the length of @store, which varies linearly with the length of the heap | ||
| # Space complexity: O(1) variables stay constant regardless of length of heap | ||
| def empty? |
There was a problem hiding this comment.
Why would this be O(n) time complexity ?
Comment on lines
+67
to
+69
| # Time Complexity: O(logn) At worse, the heap_up function will have to iterate logn times to add a heapnode from the leaf to the root of the heap | ||
| # Space Complexity: O(logn) the heap_up function doesn't store additional variables, but does make logn recursive calls to the memory stack in worst case | ||
| def heap_up(current_index) |
| raise NotImplementedError, "Method not implemented yet..." | ||
| # moves it down the heap if it's larger | ||
| # than it's children nodes. | ||
| def heap_down(current_index) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?