Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sockets - Karla #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sockets - Karla #24

wants to merge 1 commit into from

Conversation

kguadron
Copy link

No description provided.

CheezItMan
CheezItMan reviewed Sep 17, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, you hit the learning goals here. Well done.

lib/tree.rb
# Time Complexity:
# Space Complexity:
# Time Complexity: O(log(n))
# Space Complexity: O(1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are using a recursive add_helper you actually have O(log n) space complexity. Remember recursion does involve the system stack.

This also applies to your other recursive methods.

lib/tree.rb
current = @root
return bfs_array if current.nil?

# will come back to after queue exercises
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kguadron @CheezItMan