Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sockets - Evelynn #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Sockets - Evelynn #21

wants to merge 4 commits into from

Conversation

evelynnkaplan
Copy link

No description provided.

CheezItMan
CheezItMan reviewed Sep 10, 2019
View reviewed changes
Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. I like how you created methods in TreeNode to do a lot of the things recursively. Nice work doing Breadth-first-search and using your Queue data structure. Great work!

lib/tree.rb
size = 0
return 0 if self.empty?

@store.each do |i|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be a bit more efficient, if you went from front to end

lib/tree.rb
def bfs
raise NotImplementedError
if @root == nil
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good use of the Queue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CheezItMan CheezItMan CheezItMan left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evelynnkaplan @CheezItMan