Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Jillianne #46

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Ports - Jillianne #46

wants to merge 5 commits into from

Conversation

jillirami
Copy link

@jillirami jillirami commented Apr 9, 2019

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, I did not place my footer within my body tag.
Why is it important to consider and use semantic HTML? It enhances understanding for the coder and those reading the file, and eases CSS.
How did you decide to structure your CSS? I structured it from broadest organization so * rules and body layout, and then worked from top to bottom the CSS.
What was the most challenging piece of this assignment? The most challenging part was knowing when to stop and move on.
Describe one area that you gained more clarity on when completing this assignment I gained clarity on CSS grid.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? https://jillirami.github.io/

@tildeee
Copy link

tildeee commented Apr 18, 2019

Great work on this project, Jillianne! Your code looks good, and it's clean and readable.

You tried some really cool things with CSS. Nicely done!

The rule of body's width applies to all pages, so it might be worth it to pull that into your common CSS file.

As a minor usability note, your site doesn't have a way to ever return to index.html.

Regardless, good work on this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants