Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets-Bita #45

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Sockets-Bita #45

wants to merge 14 commits into from

Conversation

Bitaman
Copy link

@Bitaman Bitaman commented Apr 8, 2019

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? I had to define the language.
Why is it important to consider and use semantic HTML? It will help other programmer understand the page. it is also help people who use screen readers.
How did you decide to structure your CSS? I used the library that we used for startrly and I added a new css file and I styled my html in that. I first styled my main file and then tried to use the same classes for the similar parts on the other pages.
What was the most challenging piece of this assignment? Using grid correctly. for some part I jest gave up and used flex instead. also I am not sure if my website is responsive.
Describe one area that you gained more clarity on when completing this assignment structuring the HTML files.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling no - two pages are empty
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text You don't have any images
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall This is a good start, but it's missing some of what we're looking for in a finished project. In particular, I'm worried about your ability to quickly implement a design - it looks like you've got a handle on the learning goals, but struggled to complete all of the requirements. Practice will help here, both in being able to work quickly, and in being able to pass through the anxiety of staring at an empty page.

<body class="container">
<header class="left-navigation header nav-down">
<div class="left-navigation-wraper">
<nav>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure your editor is configured to use two-space tabs. That will make reading all this HTML a little easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants