Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Karla G. #39

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Sockets - Karla G. #39

wants to merge 7 commits into from

Conversation

kguadron
Copy link

@kguadron kguadron commented Apr 8, 2019

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, I was using
tags in correctly and I also had left behind a closing tag
Why is it important to consider and use semantic HTML? To make a website more accessible and meaningful to people who cannot access/experience it visually.
How did you decide to structure your CSS? I have a main file and then individual files for each html page. I used the same basic structure for each page. I used headers and footers and divs for the center content of the page.
What was the most challenging piece of this assignment? Getting the content to be positioned where I expected them to be. And also conceptualizing a design and how to execute it
Describe one area that you gained more clarity on when completing this assignment Flex! Once I understood the flex container and it's effect on direct children. it became a lot easier to control and predict the outcomes of my styling
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main mostly - see inline
Appropriately using semantic tags: section, article, etc. lots of <div>s that could be something more semantic
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall Great work overall - I love the parallax effect and all of the color!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants