Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Nidhi #35

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nidhiparixitpatel
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, suggestions about renaming tag.
Why is it important to consider and use semantic HTML? It is important because it is easier to understand how each line functions and easier to write CSS for semantic HTML.
How did you decide to structure your CSS? I had a styles sheet that had styles for all pages and then each page had more specific styling for that page. I tried to organize it from top to bottom of the page within each sheet.
What was the most challenging piece of this assignment? Something that was challenging for me was figuring out how to have the navbar be the same on each page.
Describe one area that you gained more clarity on when completing this assignment I learned how to use grid containers and then have flex containers inside of them.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?

@dHelmgren
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage I would like to see more frequent commits. It can be challenging to build this into your workflow when starting with a new language or style of programming, but that's also when it's most useful to have a record of what you did and how you did it.
Answered comprehension questions Yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main Yes
Appropriately using semantic tags: section, article, etc. Not so much. You didn't have a great deal of text on your site, but these tags are just as important for identifying what the meat of each page is.
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall Good work overall! It's clear to me that the learning goals for this assignment were met.

For this project, the instructors are giving a spot-check review, looking for big patterns rather than going through your code line-by-line. If you’d like a more in-depth review, please reach out to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants