Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Shamira #33

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Ports - Shamira #33

wants to merge 8 commits into from

Conversation

MiraMarshall
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? Yes, the validator suggested that I add a lang attribute to the html tag.
Why is it important to consider and use semantic HTML? For readability and to better access elements through css.
How did you decide to structure your CSS? I used flexbox for the main content.
What was the most challenging piece of this assignment? Decided how I wanted to design the site because it's personal.
Describe one area that you gained more clarity on when completing this assignment Parallax scrolling. I was really interested in using it last week but didn't have time to look into it.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? n/a

@CheezItMan
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Reasonable number of commits
Answered comprehension questions Check, glad you liked Parallax scrolling
Page fully loads Yes.... but the blog page has white text on a white background...
No broken links (regular or images) Check
Includes at least 4 pages and styling Yes, but it looks like you didn't quite finish
HTML
Uses the high-level tags for organization: header, footer, main Check
Appropriately using semantic tags: section, article, etc. Check, but you used div with classes for semantic meaning in places where you could use other tags.
All images include alternate text Check
CSS
Using class and ID names in style declarations Check
Style declarations are DRY Check
Overall Not bad, but it looks like you didn't quite finish everything.

</ul>
</nav>
<main>
<div class="about-content">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be an article tag.

<h1>About Me, Coming Soon!</h1>
<h3>Here's why I'm interesting.</h3>
</div>
<div class="about">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make this a section or article?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants