Ports - Faiza

[Faiza1987]

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question	Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they?	I had blockquote as a child of h3 which is something that is not recommended. It also told me to give headings using h1..h6 to all my articles and sections even though my page already had a heading.
Why is it important to consider and use semantic HTML?	It introduces meaning to a webpage so you know what is a paragramph, what is a title, heading, etc.
How did you decide to structure your CSS?	I used a general style for my site but made each page look a little different.
What was the most challenging piece of this assignment?	Combining Grid and flex box to look like the image I had in my mind.
Describe one area that you gained more clarity on when completing this assignment	I need to be as specific as possible when targeting for styles because the default or other styles were sometimes overwriting new styles.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?

[tildeee]

Well done on this project, Faiza! The code looks good and is readable. HOWEVER, there are some huge red flags for me!

You tend to have class names such as row and column. I'd expect that your class names could be more descriptive

Also, you use float to position items. While sometimes it's valid to use float, I would expect someone to position things using flexbox or CSS grid.

You mention in your comprehension questions that you use CSS grid, but I don't see that in your code!

Per the project requirements, I would've expected to see a normalize.css file in this project.

LASTLY, which is a HUGE red flag to me: YOU USE INLINE STYLES on your image! This is a HUGE red flag for me! Faiza, come talk to me or Chris about this sometime!