Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Mina #27

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Ports - Mina #27

wants to merge 7 commits into from

Conversation

minams
Copy link

@minams minams commented Apr 8, 2019

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? No but I did get a warning about the following:
Consider adding a lang attribute to the html start tag to declare the language of this document.
Why is it important to consider and use semantic HTML? It is important to consider and use semantic HTML because it gives meaning to the content instead of just appearance. The HTML gives content while the CSS file gives style. This helps keep things clear and concise.
How did you decide to structure your CSS? Per HTML page instead of an overall CSS file for all HTML pages.
What was the most challenging piece of this assignment? Picking which stylistic attributes.
Describe one area that you gained more clarity on when completing this assignment Understanding how the files "talk" to one another and how they relate to one another.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?

@CheezItMan
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage Good number of commits
Answered comprehension questions Check
Page fully loads Check
No broken links (regular or images) Check
Includes at least 4 pages and styling Check, but see my inline comment on your navigation
HTML
Uses the high-level tags for organization: header, footer, main
Appropriately using semantic tags: section, article, etc.
All images include alternate text Check
CSS
Using class and ID names in style declarations Check
Style declarations are DRY Check
Overall Your site works, but looks like you didn't have much time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants