Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Amy W #25

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Ports - Amy W #25

wants to merge 11 commits into from

Conversation

amythetester
Copy link

@amythetester amythetester commented Apr 8, 2019

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? The HTML Validator let me know that I should use a lang tag to declare the language of the document.
Why is it important to consider and use semantic HTML? This allows screen readers to make more sense of the code. This also helps other developers understand your intentions.
How did you decide to structure your CSS? I used CSS Grid for the base structure and Flexbox for the details of placement in each section.
What was the most challenging piece of this assignment? The CSS and normalize margins/padding. This caused some weird issues with the styling throughout the process.
Describe one area that you gained more clarity on when completing this assignment The advantages of both Flexbox and CSS Grid.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website? Nope

@tildeee
Copy link

tildeee commented Apr 16, 2019

Great work on this project, Amy! Your code is clean and readable.

You have some repeated CSS code about body and header, footer in each of your CSS pages, so it might be worth considering moving those into a shared file and including that in each page.

That being said, good work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants