-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tatiana Linked List #17
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, a few bugs and a few methods not implemented, but you hit the major learning goals here. Take a look at my comments and let me know if you have questions.
reversed_list = LinkedList.new | ||
|
||
while current.next != nil | ||
reversed_list.add_last(current) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't working because it is adding the node to the new list, rather than the node's data. It's also adding them all to the last, rather than the front.
Lastly this loop is skipping the last node in the list (check the while condition).
# Time Complexity: | ||
# Space Complexity | ||
# Time Complexity: O(n) | ||
# Space Complexity O |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Space complexity O(1)
No description provided.