Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tatiana Linked List #17

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Tatiana Linked List #17

wants to merge 6 commits into from

Conversation

tatsqui
Copy link

@tatsqui tatsqui commented Aug 26, 2019

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, a few bugs and a few methods not implemented, but you hit the major learning goals here. Take a look at my comments and let me know if you have questions.

reversed_list = LinkedList.new

while current.next != nil
reversed_list.add_last(current)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't working because it is adding the node to the new list, rather than the node's data. It's also adding them all to the last, rather than the front.

Lastly this loop is skipping the last node in the list (check the while condition).

# Time Complexity:
# Space Complexity
# Time Complexity: O(n)
# Space Complexity O

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space complexity O(1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants