forked from AdaGold/inspiration-board
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports - Elle #25
Open
dev-elle-up
wants to merge
18
commits into
Ada-C11:master
Choose a base branch
from
dev-elle-up:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Ports - Elle #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compnoent to render a list of cards from hard-coded data. Currently it will not display results that are missing fieldsbecause those are considered undefined. Need to fix this.
…s and manually tested. App is working as expected.
…hen Board is mounted. Set state of cards to the get request result. Caught errors are lifted to App via a callback function for display in the header.
…equest response. Discovered error messages were not set up properly; fixed that as far as I can tell.
… to each card. Not yet functional. Updated PropTypes.
… to each card. Not yet functional. Updated PropTypes.
…from the database. Connected this to the button's onClick event handler. Need to make the view update.
…he view. Also cleaned up some code and comments. NOTE Right now the API call is commented out for deletions. This is to preserve data for ther rest of the app development. UNCOMMENT BEFORE DEPOLYMENT OR PROJECT SUBMISSION
…added to the database. Need to implement the update to the view. Do this with setState.
… with keys allCards. Making this branch to try a fix. Move rendering of cards to the render function in board. Save all responses from the API directly to the cards array in state.
…tial get request to pull the text and emoji data out of the card object. Now need to go through and fix delete and whatever else broke in the process.
… save to the card.
…d and tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspiration Board
Congratulations! You're submitting your assignment!
Comprehension Questions