pr-6 #6
Open
pr-6 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChubbyCub
reviewed
Aug 15, 2019
|
|
||
| index = 0 | ||
| swapped = true | ||
| while index < array.length && swapped |
There was a problem hiding this comment.
Will there be an array out of bound exception right here since other_index always moves one step ahead of index? Maybe the boundary for index should only be array.length - 1
ChubbyCub
reviewed
Aug 15, 2019
| @@ -0,0 +1,25 @@ | |||
|
|
|||
| def sort(array) | |||
There was a problem hiding this comment.
This method of sorting has a time complexity of O(n^2). You might be able to improve it to have O(nlogn) time complexity by implementing quicksort
ChubbyCub
reviewed
Aug 15, 2019
| swapped = true | ||
| while index < array.length && swapped | ||
| swapped = false | ||
| other_index = index + 1 |
There was a problem hiding this comment.
other_index is not a meaningful name. You can name it adjacent_index.
ChubbyCub
reviewed
Aug 15, 2019
| while index < array.length && swapped | ||
| swapped = false | ||
| other_index = index + 1 | ||
| while other_index < array.length |
There was a problem hiding this comment.
Boundary for other_index might be wrong. it might be array.length - index - 1
ChubbyCub
reviewed
Aug 15, 2019
gracemshea
reviewed
Aug 15, 2019
| end | ||
|
|
||
| index = 0 | ||
| swapped = true |
There was a problem hiding this comment.
will this work without swapped? advise remove this second condition if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method sorts an array