Ports - Jillianne #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubha-rajan
reviewed
Mar 2, 2019
lib/array_equals.rb
Outdated
| raise NotImplementedError | ||
|
|
||
| def array_equals(array_a, array_b) | ||
| if (array_a == [] && array_b == [] || array_a == nil && array_b == nil) |
There was a problem hiding this comment.
oh wow! I like how you used a compound conditional to group all the true and false edge cases together. VERY NICE. ✨✨✨
shubha-rajan
reviewed
Mar 2, 2019
| else | ||
| array_a.length.times do |item| | ||
| if array_b[item] != array_a[item] | ||
| return false |
There was a problem hiding this comment.
It returns false as soon as it finds two chars that don't match. Brilliant! Have a 🍬
shubha-rajan
reviewed
Mar 2, 2019
| return false | ||
| end | ||
| end | ||
| return true |
There was a problem hiding this comment.
AND..... SHE STICKS THE LANDING! Returns true if all chars match. Perf. 🔥
shubha-rajan
reviewed
Mar 2, 2019
There was a problem hiding this comment.
It works and it's readable! Only thing that I would change (and this doesn't affect how the code runs at all) is that you don't have to say "if array_a == nil". Since nil is a falsey value, you could just say "if !array_a"
Other than that this is great and I can't find anything wrong with your logic.
pmanni02
reviewed
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.