Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sockets - Cyndi #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Sockets - Cyndi #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions array_equals.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
def array_equals(arr_integers_1, array_integers_2)
Copy link

@eric-andeen eric-andeen Apr 9, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parameter names are inconsistent: arr_1 and array_2.
Parameter names are also unnecessarily verbose. array1 and array2 (as in the problem statement) would be fine.

arr_integers_1.length.times do |index|
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to handle the cases of array1 == nil, array2 == nil, array1.length != array2.length. This statement DOES cover zero-length arrays.

return false if arr_integers_1[index] - array_integers_2[index] != 0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a != b is much clearer than a - b != 0, even if mathematically equivalent.

end
return true
end