Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Carla & Rosalyn #18

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Sockets - Carla & Rosalyn #18

wants to merge 6 commits into from

Conversation

ranuseh
Copy link

@ranuseh ranuseh commented Feb 23, 2019

Adagrams

Congratulations! You're submitting your assignment.

Comprehension Questions

Feature Feedback
What are the components that make up a method? Method name, parameters, block, end
What are the advantages of using git when collaboratively working on one code base? You can work on the same code remotely, you can sync your work
What kind of relationship did you and your pair have with the unit tests? It did not feel intuitive. It was difficult to create methods based on strict criteria. It was helpful in creating a more robust code where multiple scenarios were required and addressed
Does your code use any methods from the Enumerable mixin? If so, where and why was it helpful? No we did not utilize any Enumerable methods.
What was one method you and your pair used to debug code? Usage of puts statements to see results. Having someone else look over the code with fresh pair of eyes.
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share? We really enjoyed working with each other but were both surprised at how difficult the process of putting your thoughts out for other people would be. Rosalyn personally liked Carla working style of slowing down and really thinking things through before taking any action. Which is a style she would like to implement next time.

@dHelmgren
Copy link

Adagrams

What We're Looking For

Feature Feedback
General
Answered comprehension questions Yes
Both teammates contributed to the codebase Yes
Small commits with meaningful commit messages I could do with more commits, and better messages! What stuff was added at each part of Wave 3?
Code Requirements Make sure to check the instructions before you get your hands dirty with code: we asked you to put the new code in an existing file lib/adagrams.rb. :P
draw_letters method Yes
Uses appropriate data structure to store the letter distribution Yes
All tests for draw_letters pass Yes
uses_available_letters? method Yes
All tests for uses_available_letters? pass yes
score_word method Yeah!
Uses appropriate data structure to store the letter scores yes
All tests for score_word pass yes
highest_score_from method yes
Appropriately handles edge cases for tie-breaking logic yes
All tests for highest_score_from pass yes
Overall Hey y'all! Great work on this project. Your code fulfills all of the requirements and does it in a readable and reasonable way. The code is clean, and it passes all the tests!

I'm making a few comments on this assignment about some suggestions on how to refactor, but they are all optional ways of looking at this code again. Overall, you two have done a great job. Good work!


LETTER_POOL = %w(A A A A A A A A A B B C C D D D D E E E E E E E E E E E E F F G G G H H I
I I I I I I I I J K L L L L M M N N N N N N O O O O O O O O P P Q R R R R R R S S S S T T T
T T T U U U U V V W W X Y Y Z)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, but I think we can agree it's hard to read and hard to check. Is there a way to generate this from a more readable format?


def draw_letters
drawn_letters = LETTER_POOL.sample(10)
return drawn_letters

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how easy this is to read.

letters_in_hand.each do |l|
i = letters.index(l)
next if i.nil?
letters.delete_at(i)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work using delete_at rather than delete here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants