contribsys/faktory #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzcolon
reviewed
Dec 9, 2019
faktory/README.md
Outdated
| @@ -0,0 +1,101 @@ | |||
| # Faktory Helm Chart | |||
|
|
|||
| [Faktory](https://github.com/contribsys/faktory) is an open-source background jobs server written on Golang. It have got clients for different programming languages. | |||
cfaloon
reviewed
Dec 9, 2019
| [ -d test/unit ] && bats test/unit | ||
| [ -d test/acceptance ] && bats test/acceptance | ||
| # [ -d test/acceptance ] && bats test/acceptance |
There was a problem hiding this comment.
yeah, they're not really standardized and currently it's not working correctly because of a socket name length issue on docker-for-desktop. Not quite ready to include these tests as a part of the bin/package script (which automates packaging and tagging of the chart).
| @@ -0,0 +1,103 @@ | |||
| # Faktory Helm Chart | |||
StatefulSet with PVC for persistence Allows faktory license for Pro edition Config files as ConfigMap, mounted to /etc/faktory/conf.d Sidecar container with shared process namespace for the ability to detect conf.d changes and send Faktory SIGHUP UpdateStrategy OnDelete so no automatic rollouts occur with unexpected downtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds a helm chart for Contribsys Faktory.
Original convo in contribsys/faktory#19
http://contribsys.com/faktory/
https://github.com/contribsys/faktory
Features:
updatestrategy=ondeletefor no surprise downtimeApproach
Highly inspired by an initial chart by @dm3ch and some faktory deployment tips from @ecdemis123
helm/charts#13974
Used a lot of tricks and code from stable/postgres
Outstanding Issues
I'm still working on:
A sidecar inotify watcher on the configs directory that signals faktory for a hotreload when configs change.Additionally