Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected the documentation for column_type: 'boolean' #294

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Corrected the documentation for column_type: 'boolean' #294

wants to merge 1 commit into from

Conversation

edruder
Copy link

@edruder edruder commented Oct 31, 2022

  • The default value of the allow_nulls option is false, not true.
  • Added an explicit warning about NULL values when allow_nulls is false.
  • Added a test demonstrating the inconsistent behavior of NULL values when allow_nulls is false.

@edruder-block
Corrected the documentation for column_type: 'boolean'
459243e 
* The default value of the `allow_nulls` option is `false`, not `true`.
* Added an explicit warning about `NULL` values when `allow_nulls` is
  `false`.
* Added a test demonstrating the inconsistent behavior of `NULL` values
  when `allow_nulls` is `false`.
@edruder
Copy link
Author

edruder commented Oct 31, 2022

This addresses issue #293.

@edruder edruder changed the title Corrected the documentation for column_type: 'boolean' Corrected the documentation for column_type: 'boolean' Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edruder @edruder-block