fix: hopefully actually fixes bug in category builder for 'constructor' word (and other prototype stuff)

[ErikBjare]

Follow up on #564

---

🚀 This description was created by Ellipsis for commit b5e9eb0

Summary:

Updated CategoryBuilder.vue to use Map for storing words, replacing object structure to handle prototype-related issues correctly.

Key points:

• Changed data structure for storing words from object to Map in CategoryBuilder.vue.
• Replaced in keyword with Map methods (has, get, set) to avoid prototype pollution.
• Ensures words like 'constructor' are handled correctly.

---

Generated with ❤️ by ellipsis.dev

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to b5e9eb0 in 21 seconds

More details

• Looked at 26 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 additional comments because they didn't meet confidence threshold of 50%.

1. src/views/settings/CategoryBuilder.vue:227:

• Assessed confidence : 0%
• Comment:
  The changes from using an object to a Map for storing words are correctly implemented. This should prevent issues with words that match Object properties like 'constructor'. Good job on this fix.
• Reasoning:
  The PR changes the way words are stored and accessed from an object to a Map. This is a good change for handling properties that have names that could conflict with object properties (like 'constructor'). The changes are consistent and correctly implemented across the modified lines.

Workflow ID: wflow_0JibP7twdPhVnItF

---

You can customize Ellipsis with review rules, user-specific overrides, quiet mode, and more. See docs.

⌛ 12 days left in your free trial, upgrade for $20/seat/month or contact us.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.60%. Comparing base (cb83d12) to head (b5e9eb0).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #565   +/-   ##
=======================================
  Coverage   25.60%   25.60%           
=======================================
  Files          27       27           
  Lines        1613     1613           
  Branches      286      286           
=======================================
  Hits          413      413           
- Misses       1141     1174   +33     
+ Partials       59       26   -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ErikBjare]

@john30 Haven't tested (again), but I think this should be correct now.

[john30]

sorry but still not correct. as commented before, all occasions of this.words need to be checked and most probably adjusted as well.
just try the following in the browser console:
your patch would yield in behaviour such as m=new Map();m.set('example',1);console.log(Object.keys(m)) resulting in an empty array instead of an array with 'example' as the single element, because the Map can not be used like this.
instead, new Map().keys() would have to be used but it returns an iterator (and not an array as expected somewhere in the code) so that needs to be adjusted accordingly

just out of curiosity: why do you push and merge immediately before anyone had the chance to review it?

[ErikBjare]

@BelKed fixed in #569

just out of curiosity: why do you push and merge immediately before anyone had the chance to review it?

Eagerness, clearly to a fault in this case. Sorry about that. Was juggling many PRs and was hoping to get this one over with.