Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ImportError when using newer Flask version #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phonetic112
Copy link

@phonetic112 phonetic112 commented Jan 1, 2025

Importing escape is deprecated after Flask 2.3.0.


Important

Replace deprecated escape import from flask with markupsafe in custom_static.py.

  • Import Change:
    • Replace deprecated escape import from flask with markupsafe in custom_static.py.

This description was created by Ellipsis for c6554ac. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c6554ac in 7 seconds

More details
  • Looked at 17 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. aw_server/custom_static.py:30
  • Draft comment:
    The import of escape from markupsafe is correct and aligns with Flask 2.3.0 changes.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR correctly replaces the deprecated import of escape from Flask with the import from markupsafe. This aligns with the changes in Flask 2.3.0.

Workflow ID: wflow_6Puptlz7Gr5fMtRf


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant