Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BayDAG Contribution #3: CDAP estimation with joint component #769

Merged

Conversation

dhensle
Copy link
Contributor

@dhensle dhensle commented Dec 18, 2023

As part of the original BayDAG contribution, the CDAP was extended to include a joint tour component (CDAP+J). This pull request adds required code needed to create a full estimation data bundle and code to estimate the CDAP+J model. The code to fully estimate the CDAP+J is not fully finished (SANDAG decided to just re-estimate the CDAP part), but is 90% of the way there. (The only remaining part is the final building of the joint utility equations, which is in the cdap_joint_tour_utility() method.)

Required for SANDAG ABM3 production? -- No

@dhensle dhensle self-assigned this Jan 30, 2024
@dhensle dhensle force-pushed the BayDAG_cont3_cdap_plus_joint_estimation branch from 8381bff to f252006 Compare March 7, 2024 17:36
Copy link
Contributor

@i-am-sijia i-am-sijia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described in the PR, the code changes here are not fully functioning for estimating the CDAP+J model. The current estimation CI test is passing for regular CDAP, which means it's probably ok to merge this, and tackle the CDAP+J estimation in the future.

@jpn-- jpn-- merged commit ade9aa4 into ActivitySim:main Apr 1, 2024
18 checks passed
@dhensle dhensle deleted the BayDAG_cont3_cdap_plus_joint_estimation branch April 23, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants