Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce and reuse maz to maz network impedance calls to speed up runtime #490

Merged
merged 9 commits into from
Oct 27, 2021

Conversation

bstabler
Copy link
Contributor

See #431. We'll want to pull in these example expression file improvements once ready.

@bstabler bstabler marked this pull request as draft September 29, 2021 18:13
@coveralls
Copy link

coveralls commented Sep 29, 2021

Coverage Status

Coverage increased (+7.1%) to 63.587% when pulling 015dcb8 on fewer-maz-maz-data-calls-for-sandag-two-zone into ca2edd1 on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+6.4%) to 65.266% when pulling 48e25df on fewer-maz-maz-data-calls-for-sandag-two-zone into 6ba7e8f on develop.

@bstabler bstabler self-assigned this Oct 7, 2021
@esanchez01
Copy link
Contributor

@bstabler, @wusun2 and I are interested in knowing whether this change improves the 1 and 3 zone runtimes as well. I tested the 1 zone system on our machine but the runtimes varied quite heavily from run to run. From our past discussions/shared runtimes, your machine is more consistent -- have you tested the 1 and 3 zone systems on your machine?

@esanchez01
Copy link
Contributor

@bstabler, per our discussion, I applied these changes to the 1 and 3 zone setups as well. You can find the updated setups here for testing: https://github.com/esanchez01/activitysim/tree/fewer-maz-maz-data-calls-for-sandag-two-zone

@bstabler bstabler marked this pull request as ready for review October 25, 2021 03:07
…sandag-two-zone

Fewer maz maz data calls for sandag two zone
@bstabler
Copy link
Contributor Author

thanks @esanchez01, I merged your revisions

@bstabler bstabler merged commit e908573 into develop Oct 27, 2021
@bstabler bstabler deleted the fewer-maz-maz-data-calls-for-sandag-two-zone branch October 27, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants