feat: add optional sha256 to example manifest #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this can prevent upcoming benchmarking tool from pounding relentlessly on activitysim_resources repo, by caching the large file downloads
|
this is a nice improvement. @jpn-- can we add checksums to each example posted in activitysim_resources? |
|
@jpn-- please PR to develop when ready |
publish v1.0.3
this can prevent upcoming benchmarking tool from pounding relentlessly on activitysim_resources repo, by caching the large file downloads
…ysim into checksum-downloads # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
|
This PR is now ready to merge into |
|
Looks good. @jpn-- can you update the docs, probably the development and/or example rst pages, with some notes about the checksums and how to update them? Thanks. |
|
@jpn-- to update documentation |
|
@bstabler I've added some docs on checksums. If you agree they are sufficient this is ready to merge. |
|
looks good, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows an optional sha256 checksum to be added in the examples manifest. If the file to be downloaded already exists locally in the correct place and matches the checksum, we no longer re-download the file, just use the copy we already have. This can prevent upcoming benchmarking tool #439 from pounding relentlessly on activitysim_resources repo, by caching the large file downloads. (Added bonus, if we do need to download we can validate the checksum after the download and make sure the file is what was expected.)