Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated joint_tour_destination configs #357

Closed
wants to merge 1 commit into from
Closed

Updated joint_tour_destination configs #357

wants to merge 1 commit into from

Conversation

albabnoor
Copy link
Contributor

Updated joint_tour_destination.py script to point to joint_tour_destination.yaml. Added joint_tour_destination model configs files which are now separated from the non-mandatory destination choice model configs.

…nation.yaml. Added joint_tour_destination model configs files which are now separated from the non-mandatory destination choice model configs.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 81.082% when pulling 80d28eb on SEMCOG:master into 964ee00 on ActivitySim:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 81.082% when pulling 80d28eb on SEMCOG:master into 964ee00 on ActivitySim:master.

@bstabler
Copy link
Contributor

Thanks @albabnoor. Instead of creating a separate (and somewhat duplicate) set of inputs for this model, we added a include_settings option that clarifies that this submodel shares a configuration file with another submodel. The revised joint_tour_destination.yaml now simply includes the following - include_settings: non_mandatory_tour_destination.yaml.

@bstabler bstabler closed this Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants