Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warn if tap lines file not included #465

Closed
bstabler opened this issue Jul 30, 2021 · 2 comments
Closed

warn if tap lines file not included #465

bstabler opened this issue Jul 30, 2021 · 2 comments
Assignees
@bstabler

Comments

@bstabler
Copy link
Contributor

bstabler commented Jul 30, 2021 •
edited
Loading

for 3 zone system models, make tap lines file required, or at least create a warning if not included, see los.py.
@bstabler bstabler self-assigned this Jul 30, 2021
@bstabler
Copy link
Contributor Author

bstabler commented Aug 5, 2021

We decided to make the tap lines file required since all 3 zone system models to date have one

bstabler added a commit that referenced this issue Aug 7, 2021
@bstabler
doc updates for chunkless, sort for #391, require file for #465
e16c529
@bstabler
Copy link
Contributor Author

We decided to warn instead of require since this file is not included in one of the examples. This warning is now in the released version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bstabler bstabler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bstabler