Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing visibility of CHANGELOG on rubygems.org #151

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

tilo
Copy link
Contributor

@tilo tilo commented Feb 7, 2024

This PR makes the CHANGELOG.rdoc file discoverable on Rubygems.org

The screenshot shows that the reference to the CHANGELOG is currently missing:

Screenshot 2024-02-07 at 07 30 43

After merging and the next release, it will show up like this:

Screenshot 2024-02-07 at 07 33 21

Copy link
Contributor

@balvig balvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks a lot for this @tilo !

@balvig balvig merged commit 037247e into ActiveCampaign:main Feb 7, 2024
@balvig balvig mentioned this pull request Jun 19, 2024
balvig added a commit that referenced this pull request Jun 19, 2024
## What

Addresses
[error](https://app.circleci.com/pipelines/github/ActiveCampaign/postmark-gem/197/workflows/a222aad0-e4e7-41a1-a9ea-f17d7100d2fd/jobs/2173)
seen in old ruby versions since #151 :

```
[!] There was an error parsing `Gemfile.legacy`: 
[!] There was an error while loading `postmark.gemspec`: undefined method `metadata' for #<Gem::Specification:0x2e5d6c8>. Bundler cannot continue.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants