Fixed types in Voucher , VchType & GST Detail

Accounting-Companion · Nov 20, 2023 · ec51044 · ec51044
1 parent 1f0656e
commit ec51044
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/src/TallyConnector.Core/Models/GSTDetail.cs b/src/TallyConnector.Core/Models/GSTDetail.cs
@@ -104,7 +104,7 @@ public class LedgerGSTRegistrationDetails
     [XmlElement("APPLICABLEFROM")]
     public TallyDate? ApplicableFrom { get; set; }
     [XmlElement("GSTREGISTRATIONTYPE")]
-    public string? GSTRegistrationType { get; set; }
+    public GSTRegistrationType? GSTRegistrationType { get; set; }
     [XmlElement("STATE")]
     public string? State { get; set; }
     [XmlElement("PLACEOFSUPPLY")]

diff --git a/src/TallyConnector.Core/Models/Masters/VoucherType.cs b/src/TallyConnector.Core/Models/Masters/VoucherType.cs
@@ -268,7 +268,6 @@ public class VoucherClassLedger
     public CalculationMethod? MethodType { get; set; }
 
     [XmlElement(ElementName = "CLASSRATE")]
-    [Column(TypeName = "decimal(10,4)")]
     public string? ClassRate { get; set; }
 
     /// <summary>

diff --git a/src/TallyConnector.Core/Models/Voucher.cs b/src/TallyConnector.Core/Models/Voucher.cs
@@ -36,15 +36,15 @@ public Voucher()
 
     [XmlElement(ElementName = "VCHGSTCLASS")]
     [Column(TypeName = $"nvarchar({Constants.MaxNameLength})")]
-    public string VoucherGSTClass { get; set; }
+    public string? VoucherGSTClass { get; set; }
 
     [XmlElement(ElementName = "ISCOSTCENTRE")]
     [Column(TypeName = $"nvarchar({Constants.MaxNameLength})")]
     public TallyYesNo? IsCostCentre { get; set; }
 
     [XmlElement(ElementName = "COSTCENTRENAME")]
     [Column(TypeName = $"nvarchar({Constants.MaxNameLength})")]
-    public string CostCentreName { get; set; }
+    public string? CostCentreName { get; set; }
 
     [XmlElement(ElementName = "VCHENTRYMODE")]
     [Column(TypeName = $"nvarchar(30)")]