Merge pull request #43 from parassanghani6/stock-negative-qty

enable checking for negative values for stock quntity
Accounting-Companion · Apr 24, 2024 · a30e0e5 · a30e0e5
2 parents 0cfbb08 + 073be49
commit a30e0e5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/TallyConnector.Core/Converters/XMLConverterHelpers/TallyQuantity.cs b/src/TallyConnector.Core/Converters/XMLConverterHelpers/TallyQuantity.cs
@@ -71,7 +71,7 @@ public void ReadXml(XmlReader reader)
             if (content != null && content != string.Empty)
             {
                 content = content.Trim();
-                var matches = Regex.Matches(content, @"\b[0-9.]+\b");
+                var matches = Regex.Matches(content, @"-?\b[0-9.]+\b");
                 if (matches.Count == 2)
                 {
                     Number = decimal.Parse(matches[0].Value, CultureInfo.InvariantCulture);

diff --git a/src/Tests/Converters/XMLConverterHelpers/TallyQuantityTests.cs b/src/Tests/Converters/XMLConverterHelpers/TallyQuantityTests.cs
@@ -70,6 +70,23 @@ public void CheckTallyQuantity()
         });
     }
 
+    [Test]
+    public void CheckTallyNegativeQuantity()
+    {
+        string TallyQuantitytXml = "<QUANTITY> -50 Nos</QUANTITY>";
+
+        using TextReader reader = new StringReader(TallyQuantitytXml);
+        var quantity = (TallyQuantity)xmlSerializer.Deserialize(reader);
+
+        Assert.Multiple(() =>
+        {
+            Assert.That(quantity.Number, Is.EqualTo(-50));
+            Assert.That(quantity.PrimaryUnits.Number, Is.EqualTo(-50));
+            Assert.That(quantity.PrimaryUnits.Unit, Is.EqualTo("Nos"));
+            Assert.That(quantity.SecondaryUnits, Is.EqualTo(null));
+        });
+    }
+
     [Test]
     public void CheckTallyQuantitywithSecondaryUnit()
     {