Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #258

Merged
merged 3 commits into from
Jul 30, 2023
Merged

Update CI #258

merged 3 commits into from
Jul 30, 2023

Conversation

waywardmonkeys
Copy link
Contributor

No description provided.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/generate-headers.yml Outdated Show resolved Hide resolved
.github/workflows/generate-headers.yml Outdated Show resolved Hide resolved
Copy link
Member

@DataTriny DataTriny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@mwcampbell
Copy link
Contributor

@waywardmonkeys I finally got around to approving GitHub Actions for you in this repo. Looks like your changes broke a workflow. I'll let you look into it. Thanks.

@waywardmonkeys
Copy link
Contributor Author

@mwcampbell This breakage isn't from me, but is from rust-lang/rust#113152

I will submit a separate PR that fixes that and then this can move ahead after that.

@waywardmonkeys
Copy link
Contributor Author

Once #261 lands, I will rebase this forward and that error should go away.

These haven't been updated in a long time and result in warnings
within the GitHub Actions code.
@waywardmonkeys
Copy link
Contributor Author

@mwcampbell I've rebased this forward and the tests all pass now.

@waywardmonkeys
Copy link
Contributor Author

Just checking back in on this (and my other PR).

@mwcampbell mwcampbell merged commit 705ae85 into AccessKit:main Jul 30, 2023
5 checks passed
@waywardmonkeys waywardmonkeys deleted the update-ci branch July 30, 2023 14:37
lunixbochs pushed a commit to talonvoice/accesskit that referenced this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants