endpoint health #152
Merged
endpoint health #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
reviewed
Apr 5, 2024
| Ok(client) => { | ||
| let client = Arc::new(client); | ||
| health_.update(Event::ConnectionSuccessful); | ||
| _ = client_tx.send(Some(client.clone())); |
There was a problem hiding this comment.
this is success case. error is below
There was a problem hiding this comment.
I mean something like this
Suggested change
| _ = client_tx.send(Some(client.clone())); | |
| if let Err(e) = client_tx.send(Some(client.clone())) { | |
| tracing::error!("Unexpected error: {e}"); | |
| } |
xlc
approved these changes
Apr 8, 2024
| Ok(client) => { | ||
| let client = Arc::new(client); | ||
| health_.update(Event::ConnectionSuccessful); | ||
| _ = client_tx.send(Some(client.clone())); |
There was a problem hiding this comment.
I mean something like this
Suggested change
| _ = client_tx.send(Some(client.clone())); | |
| if let Err(e) = client_tx.send(Some(client.clone())) { | |
| tracing::error!("Unexpected error: {e}"); | |
| } |
kostekIV
added a commit
to Cardinal-Cryptography/subway
that referenced
this pull request
Apr 29, 2024
* subsquid indexer & processor fix (AcalaNetwork#150) * update deps (AcalaNetwork#155) * bypass cache for unfinalized blocks (AcalaNetwork#154) * endpoint health (AcalaNetwork#152) * Await healthy endpoint (AcalaNetwork#158) * use only tracing (AcalaNetwork#157) * Filter call errors (AcalaNetwork#159) * validate middleware (AcalaNetwork#156) * validate middleware * validate extension for config * rename * Improve env handling via preprocessing templated config files (AcalaNetwork#162) * Feat(config): support ${var:-word} and ${var:+word} syntax (AcalaNetwork#164) * fix cli default value (AcalaNetwork#169) * improve reconnect wait time (AcalaNetwork#168) --------- Co-authored-by: mrq1911 <lumir.mrkva@topmonks.com> Co-authored-by: Ermal Kaleci <ermalkaleci@gmail.com> Co-authored-by: Jiyuan Zheng <indirection42@outlook.com>
xlc
added a commit
that referenced
this pull request
May 18, 2024
* Revert "Refactor endpoint (#178)" This reverts commit 7fa3132. * Revert "ensure we reconnect on failure (#173)" This reverts commit 5039cfa. * Revert "improve reconnect wait time (#168)" This reverts commit 7cb7c73. * Revert "Await healthy endpoint (#158)" This reverts commit ef1c524. * Revert "endpoint health (#152)" This reverts commit cdbdd9b. * redo validate middleware * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.