Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: unspent XCM fee return #1659

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Fixed: unspent XCM fee return #1659

merged 3 commits into from
Dec 2, 2021

Conversation

syan095
Copy link
Contributor

@syan095 syan095 commented Dec 1, 2021 •
edited
Loading

Fixed a bug where unspent XCM fee is not returned from the hold registered.
Added an integration test to sure the fund is returned.

Fixes #1553

Fixed the bug where unspent XCM fee is not returned to the sovereign …
fd6a475 
…account.

Added an integration test to sure the fund is returned.
@syan095 syan095 requested review from wangjj9219 and xlc December 1, 2021 05:47
xlc
xlc previously approved these changes Dec 1, 2021
View reviewed changes
Merge remote-tracking branch 'origin/master' into fix/xcm-fee-return
3b4d0bf 
* origin/master:
  Xcm trap assets ed (#1654)
  re-benchmarked the homa-lite module (#1638)

# Conflicts:
#	runtime/integration-tests/src/relaychain/kusama_cross_chain_transfer.rs
@syan095 syan095 merged commit 2305845 into master Dec 2, 2021
@syan095 syan095 deleted the fix/xcm-fee-return branch December 2, 2021 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangjj9219 wangjj9219 wangjj9219 approved these changes

@xlc xlc xlc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XCM fee remaining is not returned to the sovereign account on XCM calls
3 participants
@syan095 @xlc @wangjj9219