Pause transaction #1333

wangjj9219 · 2021-08-15T02:55:36Z

close #1315

modules/transaction-pause/src/lib.rs

modules/transaction-pause/src/tests.rs

modules/transaction-pause/src/lib.rs

xlc · 2021-08-16T02:47:36Z

/bench runtime karura module_transaction_pause

ghost · 2021-08-16T02:47:38Z

Finished benchmark for branch: pause-transaction

Benchmark: Benchmark Runtime Karura Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-karura-runtime -- benchmark --chain=karura-latest --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

Results

Compiling acala-cli v1.3.0 (/app/git/Acala/node/cli)
Compiling primitives-proc-macro v1.3.0 (/app/git/Acala/primitives/proc-macro)
Compiling karura-runtime v1.3.0 (/app/git/Acala/runtime/karura)
Compiling acala-runtime v1.3.0 (/app/git/Acala/runtime/acala)
Compiling mandala-runtime v1.3.0 (/app/git/Acala/runtime/mandala)
Compiling polkadot-runtime v0.9.8 (https://github.com/paritytech//polkadot?rev=3a10ee63c0b5703a1c802db3438ab7e01344a8ce#3a10ee63)
Compiling kusama-runtime v0.9.8 (https://github.com/paritytech//polkadot?rev=3a10ee63c0b5703a1c802db3438ab7e01344a8ce#3a10ee63)
Compiling rococo-runtime v0.9.8 (https://github.com/paritytech//polkadot?rev=3a10ee63c0b5703a1c802db3438ab7e01344a8ce#3a10ee63)
Compiling westend-runtime v0.9.8 (https://github.com/paritytech//polkadot?rev=3a10ee63c0b5703a1c802db3438ab7e01344a8ce#3a10ee63)
Compiling orml-tokens v0.4.1-dev (/app/git/Acala/orml/tokens)
Compiling acala-primitives v1.3.0 (/app/git/Acala/primitives)
Compiling module-session-manager v1.3.0 (/app/git/Acala/modules/session-manager)
Compiling module-support v1.3.0 (/app/git/Acala/modules/support)
Compiling module-evm-rpc-runtime-api v1.3.0 (/app/git/Acala/modules/evm/rpc/runtime_api)
Compiling module-nft v1.3.0 (/app/git/Acala/modules/nft)
Compiling module-airdrop v1.3.0 (/app/git/Acala/modules/airdrop)
warning: unused import: sp_std::prelude::*
--> modules/nft/src/benchmarking.rs:23:5
|
23 | use sp_std::prelude::*;
| ^^^^^^^^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default

Compiling module-collator-selection v1.3.0 (/app/git/Acala/modules/collator-selection)
Compiling module-evm v1.3.0 (/app/git/Acala/modules/evm)
Compiling module-loans v1.3.0 (/app/git/Acala/modules/loans)
warning: 1 warning emitted

Compiling module-staking-pool-rpc-runtime-api v1.3.0 (/app/git/Acala/modules/staking-pool/rpc/runtime-api)
Compiling module-staking-pool v1.3.0 (/app/git/Acala/modules/staking-pool)
Compiling module-prices v1.3.0 (/app/git/Acala/modules/prices)
Compiling module-evm-accounts v1.3.0 (/app/git/Acala/modules/evm-accounts)
Compiling module-cdp-treasury v1.3.0 (/app/git/Acala/modules/cdp-treasury)
Compiling module-homa-validator-list v1.3.0 (/app/git/Acala/modules/homa-validator-list)
Compiling module-nominees-election v1.3.0 (/app/git/Acala/modules/nominees-election)
Compiling module-dex v1.3.0 (/app/git/Acala/modules/dex)
Compiling module-polkadot-bridge v1.3.0 (/app/git/Acala/modules/polkadot-bridge)
Compiling module-auction-manager v1.3.0 (/app/git/Acala/modules/auction-manager)
Compiling module-incentives v1.3.0 (/app/git/Acala/modules/incentives)
Compiling module-currencies v1.3.0 (/app/git/Acala/modules/currencies)
Compiling module-homa v1.3.0 (/app/git/Acala/modules/homa)
Compiling module-transaction-payment v1.3.0 (/app/git/Acala/modules/transaction-payment)
Compiling module-evm-manager v1.3.0 (/app/git/Acala/modules/evm-manager)
Compiling module-homa-lite v1.3.0 (/app/git/Acala/modules/homa-lite)
Compiling ecosystem-renvm-bridge v1.3.0 (/app/git/Acala/ecosystem-modules/ren/renvm-bridge)
Compiling module-transaction-pause v1.3.0 (/app/git/Acala/modules/transaction-pause)
Compiling ecosystem-chainsafe v1.3.0 (/app/git/Acala/ecosystem-modules/chainsafe)
Compiling ecosystem-starport v1.3.0 (/app/git/Acala/ecosystem-modules/starport)
Compiling ecosystem-compound-cash v1.3.0 (/app/git/Acala/ecosystem-modules/compound-cash)
Compiling module-cdp-engine v1.3.0 (/app/git/Acala/modules/cdp-engine)
Compiling module-emergency-shutdown v1.3.0 (/app/git/Acala/modules/emergency-shutdown)
Compiling module-staking-pool-rpc v1.3.0 (/app/git/Acala/modules/staking-pool/rpc)
Compiling module-evm-bridge v1.3.0 (/app/git/Acala/modules/evm-bridge)
Compiling cumulus-client-consensus-common v0.1.0 (https://github.com/paritytech//cumulus?rev=ed6ba5dfb2c112c29505e856e8971da3420ce6d0#ed6ba5df)
Compiling module-honzon v1.3.0 (/app/git/Acala/modules/honzon)
Compiling evm-rpc v1.3.0 (/app/git/Acala/modules/evm/rpc)
Compiling polkadot-client v0.9.8 (https://github.com/paritytech//polkadot?rev=3a10ee63c0b5703a1c802db3438ab7e01344a8ce#3a10ee63)
Compiling cumulus-primitives-parachain-inherent v0.1.0 (https://github.com/paritytech//cumulus?rev=ed6ba5dfb2c112c29505e856e8971da3420ce6d0#ed6ba5df)
Compiling cumulus-client-network v0.1.0 (https://github.com/paritytech//cumulus?rev=ed6ba5dfb2c112c29505e856e8971da3420ce6d0#ed6ba5df)
Compiling cumulus-client-consensus-aura v0.1.0 (https://github.com/paritytech//cumulus?rev=ed6ba5dfb2c112c29505e856e8971da3420ce6d0#ed6ba5df)
Compiling cumulus-client-consensus-relay-chain v0.1.0 (https://github.com/paritytech//cumulus?rev=ed6ba5dfb2c112c29505e856e8971da3420ce6d0#ed6ba5df)
Compiling acala-inspect v1.3.0 (/app/git/Acala/inspect)
Compiling polkadot-service v0.9.8 (https://github.com/paritytech//polkadot?rev=3a10ee63c0b5703a1c802db3438ab7e01344a8ce#3a10ee63)
Compiling cumulus-pallet-parachain-system v0.1.0 (https://github.com/paritytech//cumulus?rev=ed6ba5dfb2c112c29505e856e8971da3420ce6d0#ed6ba5df)
Compiling cumulus-client-collator v0.1.0 (https://github.com/paritytech//cumulus?rev=ed6ba5dfb2c112c29505e856e8971da3420ce6d0#ed6ba5df)
Compiling runtime-common v1.3.0 (/app/git/Acala/runtime/common)
Compiling cumulus-client-service v0.1.0 (https://github.com/paritytech//cumulus?rev=ed6ba5dfb2c112c29505e856e8971da3420ce6d0#ed6ba5df)
Compiling acala-rpc v1.3.0 (/app/git/Acala/rpc)
Compiling acala-service v1.3.0 (/app/git/Acala/node/service)
warning: unused import: TradingPair
--> node/service/src/chain_spec/mandala.rs:241:79
|
241 | SudoConfig, SystemConfig, TechnicalCommitteeMembershipConfig, TokensConfig, TradingPair, VestingConfig, ACA,
| ^^^^^^^^^^^
|
= note: #[warn(unused_imports)] on by default

Compiling polkadot-cli v0.9.8 (https://github.com/paritytech//polkadot?rev=3a10ee63c0b5703a1c802db3438ab7e01344a8ce#3a10ee63)
warning: 1 warning emitted

Compiling acala v1.3.0 (/app/git/Acala/node)
Finished release [optimized] target(s) in 13m 01s
Running target/release/acala benchmark --chain=karura-latest --steps=50 --repeat=20 --pallet=module_transaction_pause '--extrinsic=*' --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/
Error: Input("Error opening spec file: No such file or directory (os error 2)")

xlc · 2021-08-16T03:05:18Z

/bench runtime module module_transaction_pause

ghost · 2021-08-16T03:05:20Z

Finished benchmark for branch: pause-transaction

Benchmark: Benchmark Runtime Module

cargo run --release --color=never --bin=acala --features=runtime-benchmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./modules/transaction-pause/src/weights.rs --template=./templates/module-weight-template.hbs

Results

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 25.79
µs

Reads = 1
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 25.79
µs

Reads = 1
Writes = 1
Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 25.35
µs

Reads = 1
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 25.35
µs

Reads = 1
Writes = 1

…hmarks --features=with-mandala-runtime -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./modules/transaction-pause/src/weights.rs --template=./templates/module-weight-template.hbs

shaunxw

Will be good to have some integration tests

modules/transaction-pause/src/lib.rs

ermalkaleci · 2021-08-17T09:20:11Z

/bench runtime custom-karura --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

ghost · 2021-08-17T09:20:12Z

Finished benchmark for branch: pause-transaction

Benchmark: Benchmark Karura Runtime Custom

cargo run --release --color=never --bin acala --features=with-karura-runtime --features runtime-benchmarks -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

Results

Compiling karura-runtime v1.3.0 (/app/git/Acala/runtime/karura)
Compiling mandala-runtime v1.3.0 (/app/git/Acala/runtime/mandala)
Compiling acala-runtime v1.3.0 (/app/git/Acala/runtime/acala)
Compiling module-nft v1.3.0 (/app/git/Acala/modules/nft)
Compiling module-evm v1.3.0 (/app/git/Acala/modules/evm)
Compiling module-transaction-pause v1.3.0 (/app/git/Acala/modules/transaction-pause)
Compiling module-homa-lite v1.3.0 (/app/git/Acala/modules/homa-lite)
Compiling runtime-common v1.3.0 (/app/git/Acala/runtime/common)
Compiling module-evm-bridge v1.3.0 (/app/git/Acala/modules/evm-bridge)
Compiling evm-rpc v1.3.0 (/app/git/Acala/modules/evm/rpc)
Compiling acala-rpc v1.3.0 (/app/git/Acala/rpc)
Compiling acala-service v1.3.0 (/app/git/Acala/node/service)
Compiling acala-cli v1.3.0 (/app/git/Acala/node/cli)
Compiling acala v1.3.0 (/app/git/Acala/node)
Finished release [optimized] target(s) in 6m 11s
Running target/release/acala benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_pause '--extrinsic=*' --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/
Error: Benchmark not found for this module.

…o pause-transaction

wangjj9219 · 2021-08-17T11:47:38Z

/bench runtime custom-karura --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

ghost · 2021-08-17T11:47:39Z

Finished benchmark for branch: pause-transaction

Benchmark: Benchmark Karura Runtime Custom

cargo run --release --color=never --bin acala --features=with-karura-runtime --features runtime-benchmarks -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

Results

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 24.58
µs

Reads = 1
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 24.58
µs

Reads = 1
Writes = 1
Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

-- Extrinsic Time --

Model:
Time ~= 24.83
µs

Reads = 1
Writes = 1
Min Squares Analysis

-- Extrinsic Time --

Model:
Time ~= 24.83
µs

Reads = 1
Writes = 1

…runtime --features runtime-benchmarks -- benchmark --chain=karura-dev --steps=50 --repeat=20 --pallet=module_transaction_pause --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --template=./templates/runtime-weight-template.hbs --output=./runtime/karura/src/weights/

wangjj9219 added 2 commits August 15, 2021 10:37

add module-transaction-pause

36b9386

update

62b5590

wangjj9219 requested a review from xlc August 15, 2021 02:55

update

712584b

xlc reviewed Aug 15, 2021

View reviewed changes

modules/transaction-pause/src/lib.rs Show resolved Hide resolved

modules/transaction-pause/src/lib.rs Outdated Show resolved Hide resolved

modules/transaction-pause/src/tests.rs Outdated Show resolved Hide resolved

modules/transaction-pause/src/lib.rs Outdated Show resolved Hide resolved

update

7d42249

wangjj9219 marked this pull request as ready for review August 16, 2021 02:23

wangjj9219 requested review from xlc and shaunxw August 16, 2021 02:23

wangjj9219 added the d-needs-manual-testing label Aug 16, 2021

Merge remote-tracking branch 'origin/master' into pause-transaction

157cbb1

xlc previously approved these changes Aug 16, 2021

View reviewed changes

shaunxw previously approved these changes Aug 16, 2021

View reviewed changes

modules/transaction-pause/src/lib.rs Outdated Show resolved Hide resolved

modules/transaction-pause/src/lib.rs Outdated Show resolved Hide resolved

Acala Benchmarking Bot and others added 3 commits August 17, 2021 09:20

Merge remote-tracking branch 'origin/master' into pause-transaction

ce88c3b

fix

207f793

Merge branch 'pause-transaction' of github.com:AcalaNetwork/Acala int…

3d5454d

…o pause-transaction

wangjj9219 dismissed stale reviews from shaunxw and xlc via 3d5454d August 17, 2021 10:54

xlc approved these changes Aug 17, 2021

View reviewed changes

shaunxw approved these changes Aug 17, 2021

View reviewed changes

wangjj9219 merged commit 79471c4 into master Aug 18, 2021

wangjj9219 deleted the pause-transaction branch August 18, 2021 09:20

StrawberryFlavor added the d-manual-testing-done label Aug 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pause transaction #1333

Pause transaction #1333

wangjj9219 commented Aug 15, 2021 •

edited

Loading

xlc commented Aug 16, 2021

ghost commented Aug 16, 2021 •

edited by ghost

Loading

xlc commented Aug 16, 2021

ghost commented Aug 16, 2021 •

edited by ghost

Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

Reads = 1
Writes = 1
Min Squares Analysis

Reads = 1
Writes = 1
Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

Reads = 1
Writes = 1
Min Squares Analysis

shaunxw left a comment

ermalkaleci commented Aug 17, 2021

ghost commented Aug 17, 2021 •

edited by ghost

Loading

wangjj9219 commented Aug 17, 2021

ghost commented Aug 17, 2021 •

edited by ghost

Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

Reads = 1
Writes = 1
Min Squares Analysis

Reads = 1
Writes = 1
Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

Reads = 1
Writes = 1
Min Squares Analysis

Pause transaction #1333

Pause transaction #1333

Conversation

wangjj9219 commented Aug 15, 2021 • edited Loading

xlc commented Aug 16, 2021

ghost commented Aug 16, 2021 • edited by ghost Loading

xlc commented Aug 16, 2021

ghost commented Aug 16, 2021 • edited by ghost Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20 Median Slopes Analysis

Reads = 1 Writes = 1 Min Squares Analysis

Reads = 1 Writes = 1 Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20 Median Slopes Analysis

Reads = 1 Writes = 1 Min Squares Analysis

shaunxw left a comment

Choose a reason for hiding this comment

ermalkaleci commented Aug 17, 2021

ghost commented Aug 17, 2021 • edited by ghost Loading

wangjj9219 commented Aug 17, 2021

ghost commented Aug 17, 2021 • edited by ghost Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20 Median Slopes Analysis

Reads = 1 Writes = 1 Min Squares Analysis

Reads = 1 Writes = 1 Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20 Median Slopes Analysis

Reads = 1 Writes = 1 Min Squares Analysis

wangjj9219 commented Aug 15, 2021 •

edited

Loading

ghost commented Aug 16, 2021 •

edited by ghost

Loading

ghost commented Aug 16, 2021 •

edited by ghost

Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

Reads = 1
Writes = 1
Min Squares Analysis

Reads = 1
Writes = 1
Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

Reads = 1
Writes = 1
Min Squares Analysis

ghost commented Aug 17, 2021 •

edited by ghost

Loading

ghost commented Aug 17, 2021 •

edited by ghost

Loading

Pallet: "module_transaction_pause", Extrinsic: "pause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

Reads = 1
Writes = 1
Min Squares Analysis

Reads = 1
Writes = 1
Pallet: "module_transaction_pause", Extrinsic: "unpause_transaction", Lowest values: [], Highest values: [], Steps: [50], Repeat: 20
Median Slopes Analysis

Reads = 1
Writes = 1
Min Squares Analysis