refactor get_price #1276
Merged
refactor get_price #1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
==========================================
- Coverage 66.82% 66.37% -0.46%
==========================================
Files 225 222 -3
Lines 20095 19801 -294
==========================================
- Hits 13428 13142 -286
+ Misses 6667 6659 -8
Continue to review full report at Codecov.
|
|
This is a bit confusing. Maybe we can just have two price provider? |
xlc
reviewed
Jul 30, 2021
xlc
approved these changes
Jul 30, 2021
syan095
pushed a commit
that referenced
this pull request
Aug 10, 2021
…tegration-test * origin/master: (27 commits) Feature/homa lite improvement (#1308) payout no longer transfer rewards to owner directly (#1312) Tx priority order (#1304) to check the required collateral ratio only when withdraw collateral or issue more debit (#1311) fix interest calculation Improve ProxyType (#1288) set max collateral when close cdp has debit by dex (#1296) use the slippage for the price from oracle to limit internal swap (#1285) Update serde rule of some enum which is the param type of rpc to camel case (#1291) set fee swap path should prevent starting from native token (#1293) remove migration impl of transaction-payment (#1287) remove migration of session-manager and enable it (#1289) set end_time when create collateral auction (#1282) Update mandala (#1280) Feature/homa lite improvement (#1239) Remove KAR airdrop. (#1266) update parameters (#1279) refactor get_price (#1276) Fix coverage CI (#1267) reduce dex liquidation slippage (#1273) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1274