ensure account of native token keeps alive after charge fee #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjb0807
reviewed
Jul 13, 2021
| let native_is_enough = <T as Config>::Currency::free_balance(who) | ||
| .checked_sub(&fee_and_alive_gap) | ||
| .map_or(false, |new_free_balance| { | ||
| <T as Config>::Currency::ensure_can_withdraw(who, fee, reason, new_free_balance).is_ok() |
There was a problem hiding this comment.
Suggested change
| <T as Config>::Currency::ensure_can_withdraw(who, fee, reason, new_free_balance).is_ok() | |
| <T as Config>::Currency::ensure_can_withdraw(who, fee, reason, fee_and_alive_gap).is_ok() |
There was a problem hiding this comment.
@xlc The old code seems to be wrong.
There was a problem hiding this comment.
the last parameter is expected new balance after withdraw
There was a problem hiding this comment.
syan095
pushed a commit
that referenced
this pull request
Jul 14, 2021
* origin/master: update orml (#1206) ensure account of native token keeps alive after charge fee (#1204) bump version (#1205) Update event name mapping (#1203) update call filter to disable sudo and enable transfer & dex (#1202) refactor calculation of initial lp token (#1198) enable unsigned transaction for parachain-system (#1197) Configurable BaseXcmWeight. (#1200) Update release.md Bring back CurrencyIdConvert test. (#1199) refactor some calculation from saturating to checked (#1195) # Conflicts: # orml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charge fee maybe fail even if the account has sufficient tokens for these reasons:
Acala/modules/transaction-payment/src/lib.rs
Line 676 in ae1dba9
Acala/modules/transaction-payment/src/lib.rs
Line 593 in ae1dba9
balances::transferwill executed when swap native token andtransferrequires the receiver is alive, otherwise theswapwill fail.So fix
ensure_can_charge_feeto guarantee account will keep alive.