Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor TradingPair #1174

Merged
merged 3 commits into from
Jul 6, 2021
Merged

refactor TradingPair #1174

merged 3 commits into from
Jul 6, 2021

Conversation

wangjj9219
Copy link
Member

close #1163

xlc
xlc approved these changes Jul 5, 2021
View reviewed changes
@xlc xlc requested a review from shaunxw July 6, 2021 03:56
shaunxw
shaunxw approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@shaunxw shaunxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.unwrap() usages in runtime and chain spec could be replaced with expect("proof of not-panic...").

@wangjj9219 wangjj9219 merged commit e73b214 into master Jul 6, 2021
@wangjj9219 wangjj9219 deleted the refactor-trading-pair branch July 6, 2021 09:36
syan095 pushed a commit that referenced this pull request Jul 12, 2021
Merge remote-tracking branch 'origin/master' into feature/homa-lite
ef6cda9 
* origin/master:
  fix council origin requirement (#1193)
  update (#1191)
  Provisioning enhancement (#1183)
  enable more pallets & update parameters (#1187)
  disable total issuance check (#1179)
  bump client & spec version (#1186)
  README for the starport module (#1181)
  Added doc comments (#1180)
  export WeightToFee as pallet constant (#1184)
  refactor TradingPair (#1174)
  enable more pallets (#1175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xlc xlc xlc approved these changes

@shaunxw shaunxw shaunxw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor TradingPair
3 participants
@wangjj9219 @xlc @shaunxw