-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rez-env -c <alias> or -- <alias> (Windows CMD shell) #948
Support rez-env -c <alias> or -- <alias> (Windows CMD shell) #948
Conversation
I think this would rather belong into the cmd shell plugin instead of resolved_context. It is a shell specific issue, not platform specific. (Powershell handles it fine). |
Ah, nevermind. Just found that I am still spawning cmd shell in my powershell. :/ |
Okay, I have changed my implementation into CMD specific. |
Just checking in, is this a valid/solid solution to you guys ? :) |
Just improved the implementation, the Also, one more simple test case is added. |
Problem
As #708 stated,
rez-env pkg -c alias-cmd
orrez-env pkg -- alias-cmd
currently not supported (on Windows).Solution
Since the
Alias
object will be saved inActionManager
if any alias setup been found in package's commands byRexExecutor
, look into that list and matching them with inputcommand
, swap it back to actual command if matched, would be the simplest solution.