Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap between getargspec and getfullargspec due to getargspec deprecation #732

Conversation

maxnbk
Copy link
Contributor

@maxnbk maxnbk commented Sep 6, 2019

this is arguably the most dangerous change we need to make for py3 compatibility, and I'm not altogether sure what the consequences are, we could use some very careful review of this set of changes.

@maxnbk maxnbk added the topic:py3 Python 3 label Sep 6, 2019
@maxnbk maxnbk requested a review from nerdvegas September 6, 2019 15:53
nerdvegas pushed a commit that referenced this pull request Sep 10, 2019
@maxnbk
Copy link
Contributor Author

maxnbk commented Sep 10, 2019

closed in favor of #743

@maxnbk maxnbk closed this Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:py3 Python 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant