Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace async with block to avoid py3 async keyword #716

Merged
merged 1 commit into from
Sep 5, 2019
Merged

replace async with block to avoid py3 async keyword #716

merged 1 commit into from
Sep 5, 2019

Conversation

maxnbk
Copy link
Contributor

@maxnbk maxnbk commented Sep 4, 2019

async is a py3 keyword, so we must use something else instead. block seems appropriate.

@maxnbk maxnbk requested a review from nerdvegas September 4, 2019 18:25
@maxnbk maxnbk added the topic:py3 Python 3 label Sep 4, 2019
@nerdvegas
Copy link
Contributor

default vaue / if cond needs to be inverted

nerdvegas
nerdvegas suggested changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@nerdvegas nerdvegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invert args/if cond

@maxnbk maxnbk force-pushed the maxnbk/feat-py3-async-to-block branch from 02cb625 to a0c8f1e Compare September 4, 2019 23:41
@nerdvegas nerdvegas merged commit 125b564 into AcademySoftwareFoundation:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdvegas nerdvegas nerdvegas approved these changes

Assignees
No one assigned
Labels
topic:py3 Python 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxnbk @nerdvegas